test: apply eslint to .js files as well #19538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to lint all our JavaScript code, this would trip over tools/webpack-make.js as it's a shell script. Ignorning it still gives an eslint warning so this has to be converted to a proper JavaScript file.
jelly
added
the
no-test
martinpitt
reviewed
Oct 27, 2023
Comment on lines
+1
to
+3
| #!/bin/env node | ||
| console.error("This got renamed to ./build.js. Please see HACKING.md"); | ||
| process.exit(1); |
There was a problem hiding this comment.
I'd be in favor of just dropping this. It's been long enough now, this was only meant to adjust our muscle memory.
There was a problem hiding this comment.
Agreed, but someone suggested switching it over. Let's drop it in March then :)
martinpitt
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to lint all our JavaScript code, this would trip over tools/webpack-make.js as it's a shell script. Ignorning it still gives an eslint warning so this has to be converted to a proper JavaScript file.